Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wing auto level bug fix #9641

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

breadoven
Copy link
Collaborator

Closes #9637 and #9615.

Freezes integrator if last update time interval exceeds 5 x expected interval. Also changes I term factor to further attenuate response (may need tweaking further).

Still needs testing.

@breadoven breadoven added this to the 7.1 milestone Jan 14, 2024
@breadoven
Copy link
Collaborator Author

Testing on HITL shows the glitch you get when Auto Level is started is fixed by this PR. Reducing the I term factor related to fw_level_pitch_gain probably also helps. There's some margin for adjustment of fw_level_pitch_gain anyway from the default of 5 up to a max of 20 if a faster response is required.

Could do with some more feedback from actual testing ideally but as it stands this fix seems to work as expected.

@Jetrell
Copy link

Jetrell commented Jan 22, 2024

Could do with some more feedback from actual testing ideally but as it stands this fix seems to work as expected.

I tested this with the default gain.. And switched between different modes after the tune was complete. And the fw_level_pitch_trim value remained the same.
While before this fix, using this plane.. I would see it instantly jump to values like -8 and return to 2 again in the tuning process. Now it holds within a small margin.
So it appears to have fixed the problem.

@breadoven
Copy link
Collaborator Author

@Jetrell This fixes the starting glitch, it's more whether the PID I term factor change works for the available setting range. Doesn't seem to cause problems using the default setting in your case so may as well merge this and hope the setting range is enough to avoid problems with more twitchy craft.

@breadoven breadoven merged commit 252a3bb into iNavFlight:release_7.1.0 Jan 22, 2024
14 checks passed
@breadoven breadoven deleted the abo_fw_autolevel_fix branch April 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants