Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multirotor Only] Separate the bank angle parameter from autonomous navigation in Roll and Pitch #9677

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JulioCesarMatias
Copy link
Collaborator

@JulioCesarMatias JulioCesarMatias commented Jan 28, 2024

Breaks the old nav_mc_bank_angle parameter in two, thus distributing separate and specific parameters for the Roll and Pitch axes. And also, it adds new values, 20 for Roll and 28 for Pitch.

Depends on iNavFlight/inav-configurator#2076

@JulioCesarMatias JulioCesarMatias changed the title Separate the bank angle parameter from autonomous navigation in Roll and Pitch [Multirotor Only] Separate the bank angle parameter from autonomous navigation in Roll and Pitch Jan 28, 2024
@Jetrell
Copy link

Jetrell commented Jan 29, 2024

Tested, and it provides smoother operation.

Having Roll and Pitch as separate settings provides a better balance. By allowing the user to increase the nav_mc_bank_angle_pitch, to obtain higher forward speed and penetration into a headwind.
While its not always beneficial to set nav_mc_bank_angle_roll as high as the pitch bank angle.
Reducing it can prevent the multirotor banking too aggressively on the roll axis, causing instability under certain target conditions.

@JulioCesarMatias JulioCesarMatias added this to the 8.0 milestone Feb 2, 2024
@JulioCesarMatias JulioCesarMatias closed this by deleting the head repository Feb 4, 2024
@JulioCesarMatias
Copy link
Collaborator Author

This PR closed automatically because I accidentally deleted the repository from my GitHub... I contacted support, and they restored the repository to my account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants