Date parameter in vehicle GET request #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $stops[$j]->occupancy->{'@id'} = $URI; | ||
| $stops[$j]->occupancy->name = basename($URI); | ||
| break; |
There was a problem hiding this comment.
Isn't breaking out of a for lop not writing very ugly code? Looks like this should have been a while loop instead?
… query a vehicle for all the stops by just asking it for a certain date.
- Made sure queries for a vehicle on a certain date were available. - Cleaned up some code.
|
Thanks Stan! Took a while but it seems our work is paying off! |
toptaldev92
pushed a commit
to toptaldev92/iRail
that referenced
this pull request
Jul 29, 2021
- Made sure queries for a vehicle on a certain date were available. - Cleaned up some code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of the new kind of queries that are possible: https://api.irail.be/vehicle?id=BE.NMBS.IC2414&date=260716