Vehicle GET request #200
Closed
Vehicle GET request #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncy variables. Information is logged. One can not do more than one post request in one minute.
…into feature-postfeedback
Applied fixes from StyleCI
Enhancing your pull request
…ny Requests" will be returned. If the request is succesful however a "201 created" will be returned and the user will be redirected to the GET vehicle he posted to.
…into feature/postfeedback # Conflicts: # api/.htaccess # api/APIPost.php
…mbs and survey data. The README.md file changed for this reason.
|
|
||
| use MongoDB\Collection; | ||
|
|
||
| class SpitsgidsController |
There was a problem hiding this comment.
A Controller in a webapp is something that takes care of a HTTP call after that it has been processed by a router... This is not a controller, no?
|
It's a bit annoying that this PR also includes the other one. Let's first try to get the other PR to development and let's then look at this one! |
…elopment # Conflicts: # api/data/NMBS/vehicleinformation.php
|
Can you reopen this pull request without merge conflicts? |
|
And also make sure that if no mongodb connection could be opened, that the occupancy is not shown and the mongodb lookup is skipped. maybe we can do this using an extra .en parameter? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented following issue: #182.