Post data pushed to the feedback and occupancy table #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return 1; | ||
| break; | ||
| default: | ||
| return 2; |
There was a problem hiding this comment.
so when it's something different than these 2 URIs, you always have high occupancy?
There was a problem hiding this comment.
They can only send low medium or high and at this point it is already to late to throw error messages because this code is executed after a 201 response has been sent. What is your proposal to improve this code?
There was a problem hiding this comment.
I think the logic conclusion that you do validation before a 201 has been sent? :p
|
I will merge this PR, but we should add a TODO to do better validation |
|
@pietercolpaert agreed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue should be fully fixed now: #181.