Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: Coverage Server should log specific goal accepted #14

Closed
slowrunner opened this issue Nov 2, 2021 · 4 comments
Closed

Comments

@slowrunner
Copy link

slowrunner commented Nov 2, 2021

Currently the Coverage Server logs "Accepting goal request" when passed a proper explore goal, and continues to log actions while performing the explore goal.

The Coverage Server does not log anything for either the /dock or /undock goals. It at least should log accepting these goals (WIBNI the Coverage Server logged what goal was accepted), and success or failure.

UPDATE: This issue asks that the "Accepting goal request" log the specific goal:

"Accepting goal request {explore | dock | undock | wall_follow}"

and log the same completion for dock, undock, wall_follow as is logged for explore:

[INFO] [1635860215.373907229] [create3_coverage]: Coverage action terminated

@alsora
Copy link
Collaborator

alsora commented Nov 2, 2021

The dock and undock actions commanded by the coverage server are implementation details.
I think it's better to just print that a behavior is starting, as you described in #11

@slowrunner
Copy link
Author

no problem with that - loving anything you all can get to. I'm just having fun playing with you all's code.

@slowrunner slowrunner changed the title FeatureRequest: Coverage Server should log dock and undock actions FeatureRequest: Coverage Server should log dock and undock goals Nov 2, 2021
@slowrunner
Copy link
Author

slowrunner commented Nov 2, 2021

Changed the title to reflect comment
to "log goals" instead of "log actions".

Issue #11 addresses that the explore goal has told the sim to do something and the bot can be seen moving, but nothing will be visible in the coverage server output until an individual coverage server behavior (of the explore action) completes.

This issue asks that the "Accepting goal request" log the specific goal:

"Accepting goal request {explore | dock | undock | wall_follow}

and log the same completion for dock, undock, wall_follow as is logged for explore:

[INFO] [1635860215.373907229] [create3_coverage]: Coverage action terminated

@slowrunner slowrunner reopened this Nov 2, 2021
@slowrunner slowrunner changed the title FeatureRequest: Coverage Server should log dock and undock goals FeatureRequest: Coverage Server should log specific goal accepted Nov 2, 2021
@slowrunner
Copy link
Author

I see my confusion now - the /undock and /dock goals (and wall follow) are not going to the coverage server at all - they are subscribed to by the bot/sim - so the Coverage server will not display "Accepting goal" for them.

Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants