fix(view): improve view disposal by removing resize listener

iTowns · Mar 6, 2023 · 6f4ec34 · 6f4ec34
1 parent c83bfcf
commit 6f4ec34
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Core/View.js b/src/Core/View.js
@@ -185,7 +185,8 @@ class View extends THREE.EventDispatcher {
 
         this._frameRequesters = { };
 
-        window.addEventListener('resize', () => this.resize(), false);
+        this._resizeListener = () => this.resize();
+        window.addEventListener('resize', this._resizeListener, false);
 
         this._changeSources = new Set();
 
@@ -258,6 +259,9 @@ class View extends THREE.EventDispatcher {
             console.warn('View already disposed');
             return;
         }
+
+        window.removeEventListener('resize', this._resizeListener);
+
         // controls dispose
         if (this.controls) {
             if (typeof this.controls.dispose === 'function') {