Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unit tests issues with node latest published version (21.5.0) #2254

Open
mgermerie opened this issue Jan 9, 2024 · 1 comment
Open
Assignees
Labels

Comments

@mgermerie
Copy link
Contributor

mgermerie commented Jan 9, 2024

Your Environment

  • Version used: 2.41.0
  • Node version: 21.5.0 (latest published version)
  • npm version: 10.2.4

Context

Trying to run unit tests on Node current version (21.5.0) brings warnings and errors :

if (!global.navigator) {
    global.navigator = { userAgent: 'firefox' }
}
  • When applying the previous fix, we get a deprecation warning :
(node:29868) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

Steps to Reproduce (for bugs)

  1. Download and use node 21.1.0
  2. run npm install
  3. run npm run test-unit
  4. You can see the deprecation message after applying the fix in #

Possible Cause/Fix/Solution

The first point is fixed in #2255.

@Desplandis
Copy link
Contributor

Can confirm that this issue starts with node >= 21.0.0, latest LTS (20.x.x) is not impacted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants