fix(tests): prevent overwriting navigator.userAgent
#2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgermerie
force-pushed
the
fix/test-node21
branch
from
66fceb8
to
b70e11a
Compare
Desplandis
requested changes
Jan 10, 2024
This property has been made read-only in node 21.1.0
mgermerie
force-pushed
the
fix/test-node21
branch
from
b70e11a
to
a4ce9a1
Compare
Desplandis
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing
iTownsconventions on PRs, Git history and code.Description
As discussed in #2254, the
navigator.userAgenthas been made read-only in node 21.1.0 (see this commit).In this PR, we check if navigator is already set (allegedly by node). If that's the case, we don't overwrite it.