Cleanup visibility #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces setVisible/setDisplayed to remove the ambiguity between using node.visible (is the node visible?) and node.material.visible (is this node displayed). Also limits the number of places modifying visibility/displayed properties to help understand where/why these are changed.
Simplify BrowseTree logic to improve readability:
- use 'action' parameter instead of several booleans
- introduce variable with descriptive names (disposableChildrenCount,
isVisible, wasVisible, etc)
gchoqueux
added a commit
that referenced
this pull request
Jun 15, 2016
gchoqueux
added a commit
that referenced
this pull request
Jun 15, 2016
|
Thx, good job |
NikoSaul
pushed a commit
to NikoSaul/itowns2
that referenced
this pull request
Jul 4, 2017
NikoSaul
pushed a commit
to NikoSaul/itowns2
that referenced
this pull request
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this PR is to improve the readability of the code handling tile visibility.
It contains some of the ideas from @Jeremy-Gaillard 's PR #71 and should help fixing bug #82
@gchoqueux could you review this PR?