Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadtree #90

Merged
merged 3 commits into from
Jul 1, 2016
Merged

Quadtree #90

merged 3 commits into from
Jul 1, 2016

Conversation

Jeremy-Gaillard
Copy link
Contributor

This PR aims at clarifying the role of Quadtree. Quadtree no longer has up, down and upSublayer functions. The divide function has been added, which returns an array of bounding boxes.

Visibility and tile creation operations are moved to Nodeprocess, allowing most visibility changes to happen in the same class.

Jérémy Gaillard added 2 commits June 22, 2016 17:18
Previously only existed in NodeMesh.
… NodeProcess.

Only the level-0 tiles are still created inside Quadtree.
@mbredif
Copy link
Collaborator

mbredif commented Jun 22, 2016

I support the idea of having the Quadtree only concerns about geometric subdivision. Ideally, it could be interchangeable with an octree, kdtree or whatever bounding volume hierarchy.
Why do you keep initial tile creation in the Quadtree ?

Furthermore, why is a Quadtree a layer rather than a layer using a quadtree ? I imagine a quadtree could be shared between different layers for instance.

@Jeremy-Gaillard
Copy link
Contributor Author

At the moment, I don't think it is possible to move the initial tile creation out without a lot of modifications to the tile creation mechanism (see #71. I am actually integrating bits of #71 to ease the process).

I agree that the layer is weirdly defined currently. There should be a difference between the layer and the data structure. It will be addressed in another PR. I will open an issue regarding that matter.

@@ -84,6 +84,36 @@ define('Scene/NodeProcess',

};

NodeProcess.prototype.subdivide = function (node, camera, params) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function only uses params.tree so it would make sense to change the third argument to quadtree

gchoqueux added a commit that referenced this pull request Jul 1, 2016
@gchoqueux gchoqueux merged commit 7cf9485 into iTowns:master Jul 1, 2016
gchoqueux added a commit that referenced this pull request Jul 1, 2016
#62 add api functions : removeImageryLayer, moveLayerToIndex
NikoSaul pushed a commit to NikoSaul/itowns2 that referenced this pull request Jul 4, 2017
NikoSaul pushed a commit to NikoSaul/itowns2 that referenced this pull request Jul 4, 2017
iTowns#62 add api functions : removeImageryLayer, moveLayerToIndex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants