Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a11y violations for Tree examples #1492

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Conversation

r100-stack
Copy link
Member

@r100-stack r100-stack commented Aug 14, 2023

Changes

aria-owns expects a space separated list of ids (MDN docs). However, we were passing a comma separated list of ids. I corrected this mistake and added a short changeset.

Testing

Confirmed that the cypress-axe TreeMainExample test passes.

Docs

N/A

@r100-stack r100-stack self-assigned this Aug 14, 2023
@r100-stack r100-stack marked this pull request as ready for review August 14, 2023 21:36
@r100-stack r100-stack requested review from a team as code owners August 14, 2023 21:36
@r100-stack r100-stack requested review from mayank99 and removed request for a team August 14, 2023 21:36
Co-authored-by: Mayank <9084735+mayank99@users.noreply.github.com>
@mayank99 mayank99 merged commit 92bdc0c into dev Aug 15, 2023
11 of 13 checks passed
@mayank99 mayank99 deleted the rohan/a11y-violations-tree branch August 15, 2023 17:56
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants