New popover #1506
Merged
New popover #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
commented
Sep 11, 2023
| // max-height must be on the outermost element for virtual scroll | ||
| maxBlockSize: | ||
| 'calc((var(--iui-component-height) - 1px) * 8.5)', | ||
| overflowY: isOverflowOverlaySupported() ? 'overlay' : 'auto', |
There was a problem hiding this comment.
since we are now using iui-menu as the outer element, we don't need to set these inline styles for virtualization
while writing this, i also realized that we can remove iui-scroll and make it the default behavior. this will fix #1301 as well. i will create a separate PR for it
r100-stack
reviewed
Sep 11, 2023
r100-stack
reviewed
Sep 11, 2023
Co-authored-by: Rohan Kadkol <45748283+rohan-kadkol@users.noreply.github.com>
r100-stack
reviewed
Sep 11, 2023
packages/itwinui-react/src/core/Table/filters/DateRangeFilter/DatePickerInput.tsx
Show resolved
Hide resolved
r100-stack
reviewed
Sep 11, 2023
r100-stack
reviewed
Sep 11, 2023
Co-authored-by: Rohan Kadkol <45748283+rohan-kadkol@users.noreply.github.com>
r100-stack
reviewed
Sep 11, 2023
r100-stack
reviewed
Sep 11, 2023
Co-authored-by: Rohan Kadkol <45748283+rohan-kadkol@users.noreply.github.com>
r100-stack
approved these changes
Sep 11, 2023
Ohh, sorry, I missed this message. I reviewed and approved it. There were a few parts that involved concepts that I don't understand too well. But for the parts that I did understand, I reviewed them better. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Continued from #1392
Replaced old tippy-based private
Popovercomponent with new floatingui-based privateusePopoverhook and publicPopovercomponent.Popoverdefaults torole=dialogand does some focus management, whereasusePopovergives more control and is useful for internal components that bring their own logic for roles and focus management and custom triggers. The publicPopoveris also used in some internal components that do not need such custom logic.Removed old
popover.scss; it was mainly used for reverting tippy styles (which don't exist anymore). The new popover does not need any CSS but also does not come with any animations (can be added in the future).The public
Popoverhas anapplyBackgroundprop which converts it into a Surface. Since this is a new component, I've decided not expose all floating-ui props to keep API surface small; we can re-evaluate in the future based on user requests.Testing
Thoroughly tested all affected components in storybook and vite playground.
Here's a screen recording showing various components in action:
Screen.Recording.2023-09-08.at.12.15.36.PM.mov
Updated all affected unit tests.
Docs
Changesets added. Pending documentation for
Popover(future PR).