remove nested toasters #2153
Merged
remove nested toasters #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
force-pushed
the
mayank/remove-redundant-toasters
branch
3 times, most recently
from
ad1969c
to
826cadf
Compare
mayank99
force-pushed
the
mayank/remove-redundant-toasters
branch
from
9a51e2a
to
46ba2ad
Compare
mayank99
force-pushed
the
mayank/remove-redundant-toasters
branch
from
46ba2ad
to
0d31173
Compare
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
Ben-Pusey-Bentley
approved these changes
Jul 24, 2024
This was referenced Jul 26, 2024
Closed
r100-stack
approved these changes
Jul 29, 2024
| '@itwin/itwinui-react': minor | ||
| --- | ||
|
|
||
| Nested `ThemeProvider`s will now reuse the same toaster instead of creating new ones. |
There was a problem hiding this comment.
Should this be "toast wrapper" instead of "toaster"?
There was a problem hiding this comment.
I used "toaster" because that's the terminology that our users are more familiar with, and because it's also more accurate, since we are now actually using the same reducer (rather than just the same DOM element).
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates the
PortalContainerlogic so that instead of creating a new<Toaster>for every single<ThemeProvider>, the same one will be reused (if found).This sounds like an optimization, but it is actually a bug fix. Previously, when multiple toasts from different
toasters were triggered at the same time, they would end up in different containers that are positioned in the same place and therefore overlap each other. With this change, they use the same container and do not overlap.Note: This PR does not handle redundancy for the special case when a
portalContainerprop is used; which means we still create new toasters even when differentThemeProviders use the sameportalContainer(this can be seen if you inspect the<body>element on some docs pages). This is something I'd like to fix in the future.Testing
Tested manually and added e2e tests to confirm desired behavior.
Before:
After:
For some reason, test images in
TableandDatePickerchanged. I have no clue why. I did verify that elements are still correctly focused; the only difference is that the focus ring is sometimes not visible when using mouse (which matches how:focus-visibleworks).Docs
Added
minorchangeset.