Presentation: Set serialized responses as Napi::Buffer to avoid copying native string to Napi::String
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring to `Napi::String`
grigasp
requested review from
a team,
pmconne,
swwilson-bsi,
khanaffan,
kabentley,
calebmshafer and
bbastings
as code owners
saskliutas
approved these changes
May 17, 2023
pmconne
approved these changes
May 17, 2023
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #275.
The change doesn't fix the problem altogether, but makes the request:
The consolidated descriptor request will still fail for the iModel mentioned in the Sentry report due to massive amount of duplicated aspects in the iModel. The request is to load all properties of all aspects and the response is 700+ MB serialized JSON string. Node supports up to 512 MB strings and fails.
itwinjs-core PR: iTwin/itwinjs-core#5534
itwinjs-core: https://github.com/iTwin/itwinjs-core/tree/presentation/accept-buffer-responses-from-addon