Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fix imodel react hooks #763

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ben-bartholomew
Copy link

Some of the tests for useFeatureOverrides in the package imodel-react-hooks were skipped during a previous upgrade. These changes fix and re-enable them.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@MichaelBelousov MichaelBelousov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I hesitate to let this through without adding a test that confirms there are no longer any feature overrides in the provider list after unmounting...

basically we only test the hook, not the provider. But if someone confirms that it works locally after viewport unmount, then I don't mind skipping adding it for now if it's too much overhead

@ben-bartholomew
Copy link
Author

Fixing exists tests that were commented out is one thing, but I don't think I have the bandwidth or the expertise to add a new test that does something like that.

FWIW I gave it a try, but its an internal variable that disappears when the component unmounts; something clever will have to be done to get access to it without exposing it to consumers of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants