Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot load this model #72

Closed
ugurdogrusoz opened this issue Oct 14, 2015 · 9 comments
Closed

Cannot load this model #72

ugurdogrusoz opened this issue Oct 14, 2015 · 9 comments

Comments

@ugurdogrusoz
Copy link
Contributor

This model imported from Reactome wont load! Can we find out why not? I changed the file extension so github issue tracker can attach it.
391160.sbgn.txt

@metincansiper
Copy link
Collaborator

The reason why it cannot be loaded is that the class of some nodes in this file is "annotation" which is not handled in sbgnviz.

@ugurdogrusoz
Copy link
Contributor Author

Can we change our reader to "skip" such unrecognized classes?

@metincansiper
Copy link
Collaborator

Is skipping these classes means that when an element has one of these classes drawing it as a normal element(an element with no specific sbgnclass)?

@ugurdogrusoz
Copy link
Contributor Author

Can't we just "ignore" them? "annotation" must be inside a glyph or arch, a property of a node or an edge that SBGNViz would not understand or care about. We should just skip such unrecognized elements.

@cannin
Copy link

cannin commented Oct 20, 2015

Can you draw them as shown below? I think there are several glyphs that I do not think you are supporting. Ideally, you'd have them all, but in the meantime, can you put a simple placeholder, so that people at least know something was there and what it was supposed to be?

screen shot 2015-10-20 at 10 57 42 am

@ugurdogrusoz
Copy link
Contributor Author

I am confused Augustin. Are these "annotation"s actually units of information?

@cannin
Copy link

cannin commented Oct 21, 2015

The proposed solution is a hack. While I think SBGNViz should support all the SBGN glyphs, I understand there can be resource limitations in implementing everything. I would rather see a default visualization of an unknown glyph instead of it disappearing from the diagram completely. The suggested rectangle would hopefully be a very simple way of doing the default representation of an unknown glyph.

metincansiper added a commit that referenced this issue Oct 23, 2015
@metincansiper
Copy link
Collaborator

Just ignored the unrecognized classes at least for now.

@selimfirat
Copy link

This issue was moved to iVis-at-Bilkent/chise.js#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants