Skip to content

Commit

Permalink
st/nine: Always return OK on SetSoftwareVertexProcessing
Browse files Browse the repository at this point in the history
This would need more tests to know exactly
if INVALIDCALL can be returned in some
situations.
It seems some games expect D3D_OK,
even when noop and illegal.

Fixes:
#302
#338

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
  • Loading branch information
axeldavy committed Apr 9, 2019
1 parent a3df31b commit cb54ef9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/gallium/state_trackers/nine/device9.c
Original file line number Diff line number Diff line change
Expand Up @@ -2728,7 +2728,7 @@ NineDevice9_SetSoftwareVertexProcessing( struct NineDevice9 *This,
nine_context_set_swvp(This, bSoftware);
return D3D_OK;
} else
return D3DERR_INVALIDCALL; /* msdn. TODO: check in practice */
return D3D_OK; /* msdn seems to indicate INVALIDCALL, but at least Halo expects OK */
}

BOOL NINE_WINAPI
Expand Down

0 comments on commit cb54ef9

Please sign in to comment.