Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrek 2 (in 1) #105

Closed
dungeon007 opened this issue Mar 26, 2021 · 1 comment
Closed

Shrek 2 (in 1) #105

dungeon007 opened this issue Mar 26, 2021 · 1 comment

Comments

@dungeon007
Copy link

Might be some similar cause like in #97 , but anyway since no one commented, no idea maybe it was not so clear there 馃ぃ. Anyway, here i go again since this is more or less common with nine, it might help...

Shrek 2, this is Unreal Engine 2 D3D8 game, so d3d8to9 involved...

DXVK (either by radv or via amdvlk) render both water reflection and shadow correctly.
WINED3D render reflection correcty, but shadows incorrectly... shadow looks too dark.
NINE render both reflections and shadows incorrectly. Shadows too dark like WINED3D and reflection is something like a opposite of what it should reflect.

Trace here: https://drive.google.com/file/d/123rQrMUIjLvIDCe1sgw1eK5keuwpG-he/view?usp=sharing
@axeldavy
Copy link
Collaborator

Thanks for the trace. I managed to fix the two issues (two unrelated ff issues) with the trace. Will be pushed shortly.

axeldavy added a commit to iXit/Mesa-3D that referenced this issue Mar 27, 2021
@axeldavy
st/nine: Fix ff has_aNrm computation
a2823be 
In some cases the wrong computation led the
normal to be zero instead of the correct value,
which led to artifacts.

Fixes: iXit/wine-nine-standalone#105

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
@dungeon007 dungeon007 mentioned this issue Mar 27, 2021
Closed
@dungeon007 dungeon007 mentioned this issue Apr 8, 2021
Open
axeldavy added a commit to iXit/Mesa-3D that referenced this issue Apr 10, 2021
@axeldavy
st/nine: fix ps ff BLENDTEXTUREALPHA
9fa1c42 
This ff ps operation has the texture alpha as input.
Thus we need to sample the texture.

Fixes: iXit/wine-nine-standalone#105

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
axeldavy added a commit to iXit/Mesa-3D that referenced this issue Apr 10, 2021
@axeldavy
st/nine: Fix ff has_aNrm computation
d9638d9 
In some cases the wrong computation led the
normal to be zero instead of the correct value,
which led to artifacts.

Fixes: iXit/wine-nine-standalone#105

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
axeldavy added a commit to iXit/Mesa-3D that referenced this issue Apr 11, 2021
@axeldavy
st/nine: Fix ps ff BLENDTEXTUREALPHA
ab076a8 
This ff ps operation has the texture alpha as input.
Thus we need to sample the texture.

Fixes: iXit/wine-nine-standalone#105

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
axeldavy added a commit to iXit/Mesa-3D that referenced this issue Apr 11, 2021
@axeldavy
st/nine: Fix ff has_aNrm computation
efcc35c 
In some cases the wrong computation led the
normal to be zero instead of the correct value,
which led to artifacts.

Fixes: iXit/wine-nine-standalone#105

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axeldavy @dungeon007