Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BASE64_MIME_PERMISSIVE to ignore trailing bits #103

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Add BASE64_MIME_PERMISSIVE to ignore trailing bits #103

merged 3 commits into from
Apr 9, 2024

Conversation

wathiede
Copy link
Contributor

@wathiede wathiede commented Apr 9, 2024 •
edited by ia0

Fixes #102

@ia0 ia0 changed the title Add BASE64_MIME_PERMISSIVE based on BASE64_MIME but allows trailing bits Add BASE64_MIME_PERMISSIVE to ignore trailing bits Apr 9, 2024
ia0
ia0 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Owner

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! I made some minor style changes and updated the version and changelog. Once it passes CI I'll merge it.

@ia0 ia0 merged commit 59549dd into ia0:main Apr 9, 2024
2 checks passed
@ia0
Copy link
Owner

ia0 commented Apr 28, 2024

This change has been published as part of 2.6.0 in #104.

@wathiede
Copy link
Contributor Author

Thanks! I've now pinged staktrace/mailparse#125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia0 ia0 ia0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider check_trailing_bits=false for BASE64_MIME decoder
2 participants
@wathiede @ia0