Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no_std #41

Closed
wants to merge 1 commit into from
Closed

Fix no_std #41

wants to merge 1 commit into from

Conversation

koushiro
Copy link

Signed-off-by: koushiro koushiro.cqx@gmail.com

@ia0 Please release a patch version after merging this PR

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@ia0
Copy link
Owner

ia0 commented Jan 18, 2021

Hi @koushiro,

Thanks for the PR! However, I think this is not needed. Did you try to update your .cargo/config.toml as described here? Also, note that this should not be needed anymore with recent rustc versions, although I did not have time to try yet.

@ia0 ia0 self-requested a review January 18, 2021 15:56
@ia0 ia0 assigned ia0 and unassigned ia0 Jan 18, 2021
@koushiro
Copy link
Author

@koushiro
Copy link
Author

you could run the command cargo build --target thumbv6m-none-eabi under the path data-encoding/lib/macro

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 94.274% when pulling 3cfa5f7 on koushiro:fix-no-std into 7fefb4a on ia0:master.

@ia0
Copy link
Owner

ia0 commented Jan 18, 2021

Thanks for the link, I've added a comment there. I'm closing the issue here.

See also #35 for previous discussions regarding multiformats/rust-multibase.

@ia0 ia0 closed this Jan 18, 2021
@koushiro koushiro deleted the fix-no-std branch January 19, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants