Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest docker container for tfsec #7

Merged
merged 1 commit into from
May 5, 2021

Conversation

owenrumney
Copy link
Contributor

@owenrumney owenrumney commented May 5, 2021

tfsec has moved from liamg/tfsec docker hub to tfsec/tfsec

@yi2020
Copy link
Contributor

yi2020 commented May 5, 2021

Good catch, thank you @owenrumney . We now need to re-run the tests with this container. Do you want to do it, or shall we merge this PR and I'll open a new one with the execution results?

Basically what you need to do is:

  1. Clear up the tfsec results that are in the repo with find . -name "tfsec_results.txt" -exec rm {} \;.
  2. Run the run_all_tools.sh script.
  3. See if there are any cases where tfsec didn't catch the issue before, and does now, and update the results_summary.json to reflect that.
  4. Run the generate_readme_tables.py script to regenerate the tables, and replace them in the README.md file.

If you see a better way to doing this, let's improve the process. This is a collaborative effort.

@yi2020 yi2020 self-requested a review May 5, 2021 17:25
@owenrumney
Copy link
Contributor Author

Hey @yi2020 - if you're happy to just merge it and it'll get picked up on the next execution. I don't have a CLOUDRAIL_API_KEY so doesn't look like I'll get the full results.

@yi2020
Copy link
Contributor

yi2020 commented May 5, 2021

No problem, I'll take care of it.

@yi2020 yi2020 merged commit 2b84a94 into iacsecurity:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants