-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gradient boosting classifiers #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
===========================================
+ Coverage 99.77% 100.00% +0.22%
===========================================
Files 11 12 +1
Lines 440 559 +119
===========================================
+ Hits 439 559 +120
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
This pull request introduces 4 alerts when merging 6df5bcb into 0a42d68 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 63d5ca3 into 0a42d68 - view on LGTM.com new alerts:
|
This pull request fixes 7 alerts when merging cf9da61 into 0a42d68 - view on LGTM.com fixed alerts:
|
…ass for _more_tags Based off LGTM feedback
The case of mismatched type between target field and score distribution value was unaccounted for
This pull request fixes 8 alerts when merging 6e698c0 into 0a42d68 - view on LGTM.com fixed alerts:
|
The long awaited gradient boosting model support is finally here.
I have found that PMML generation for GBM models is unfortunately not very consistent. I had to account for many different versions which resulted in a rather massive change.
There are some parts I am yet uncertain about:
Target.rescaleFactor
seems related. I've added a FIXME note, and it should be revisited when supporting regression trees outside of gradient boosting.pypmml
. This seems happen atsklearn-pmml-model/sklearn_pmml_model/tree/tree.py
Line 224 in 27cc103
After this PR, supporting regression should be fairly straightforward.
Closes #20