Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support major release of scikit-learn 1.x #37

Merged
merged 6 commits into from Jan 23, 2022
Merged

Conversation

iamDecode
Copy link
Owner

Since scikit-learn officially released 1.0 the API has changed a bit. Mostly renaming, but sufficient for breaking sklearn-pmml-model. This PR resolves those issues while staying compatible with previous (recent) 0.x versions

@height

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #37 (24de56d) into master (186c065) will decrease coverage by 0.39%.
The diff coverage is 92.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #37      +/-   ##
===========================================
- Coverage   100.00%   99.60%   -0.40%     
===========================================
  Files           16       16              
  Lines          967     1004      +37     
===========================================
+ Hits           967     1000      +33     
- Misses           0        4       +4     
Impacted Files Coverage Δ
sklearn_pmml_model/naive_bayes/implementations.py 95.65% <50.00%> (-4.35%) ⬇️
sklearn_pmml_model/base.py 98.87% <66.66%> (-1.13%) ⬇️
sklearn_pmml_model/ensemble/forest.py 100.00% <100.00%> (ø)
sklearn_pmml_model/ensemble/gb.py 100.00% <100.00%> (ø)
sklearn_pmml_model/linear_model/implementations.py 100.00% <100.00%> (ø)
sklearn_pmml_model/svm/_base.py 100.00% <100.00%> (ø)
sklearn_pmml_model/svm/_classes.py 100.00% <100.00%> (ø)
sklearn_pmml_model/tree/tree.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186c065...24de56d. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 23, 2022

This pull request fixes 2 alerts when merging 24de56d into 186c065 - view on LGTM.com

fixed alerts:

  • 2 for Missing call to `__init__` during object initialization

@iamDecode iamDecode merged commit 18e2e58 into master Jan 23, 2022
@iamDecode iamDecode deleted the decode/sklearn-1.0 branch January 23, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant