Change qrand() , Use QRandomGenerator instead in QT > 5.10.0 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamantony
reviewed
Jun 30, 2020
|
I agree QT_VERSION_CHECK more readable . |
iamantony
reviewed
Jun 30, 2020
sources/writer.cpp
Outdated
| @@ -180,7 +184,11 @@ QString WriterPrivate::getTempFileName() | |||
|
|
|||
| for (int counter = 0; counter < std::numeric_limits<int>::max(); ++counter) | |||
| { | |||
| QString name = nameTemplate.arg(QString::number(qrand())); | |||
| #if (QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)) | |||
| QString name = nameTemplate.arg(QString::number(QRandomGenerator::global()->generate())); | |||
There was a problem hiding this comment.
Please fix indent on lines 188 and 190.
|
Thanks @gakramx for your contribution! |
|
you are welcome @iamantony |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for Old Pull requests
I was supposed to check it well
So
When trying to build with Cmake on my system :
The error message :
In QT documentation :
Note: This function is deprecated. In new applications, use QRandomGenerator instead. in QT > 5.10.0
https://doc.qt.io/qt-5/qtglobal-obsolete.html#qrand
After changing qrand() it was built without any problems .