[Feature Request] Upstream the zsh completions

[NicolaSmaniotto]

It would be nice to upstream the zsh completions file present in the AUR, to make it available for other distributions and have a place to maintain it in case something changes in the future.

[iamkroot]

Thanks for creating the issue! I've been lazy about this, and I looked into it a bit.

We use Cleo under the hood to create the CLI, and turns out, it has built-in support for bash, zsh and fish autocompletions).

You just need to follow the steps from the link and the completions will be generated!
@ahmubashshir Maybe you can update the PKGBUILD to do this instead of pre-generating them?

[ahmubashshir]

Okay, I'll look into it. Mubashshir

…

On Mon, Jan 31 2022 at 08:56:20 AM -0800, Krut Patel ***@***.***> wrote: Thanks for creating the issue! I've been lazy about this, and I looked into it a bit. We use Cleo under the hood to create the CLI, and turns out, it has built-in support for bash, zsh and fish autocompletions). You just need to follow the steps from the link and the completions will be generated! @ahmubashshir Maybe you can update the PKGBUILD to do this instead of pre-generating them? — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: ***@***.***>

[ahmubashshir]

BTW, 'plex' subcommand description is probably incorrect, ``` $ trakts help ... auth Runs the authentication flow for trakt.tv ... plex Runs the authentication flow for trakt.tv ... ``` Mubashshir On Mon, Jan 31 2022 at 11:10:29 PM +0600, Mubashshir ***@***.***> wrote:

…

Okay, I'll look into it. Mubashshir On Mon, Jan 31 2022 at 08:56:20 AM -0800, Krut Patel ***@***.***> wrote: > Thanks for creating the issue! I've been lazy about this, and I > �looked into it a bit. > > We use Cleo under the hood to create the CLI, and turns out, it has > �built-in support for bash, zsh and fish autocompletions). > > You just need to follow the steps from the link and the completions > �will be generated! > @ahmubashshir Maybe you can update the PKGBUILD to do this instead > of �pre-generating them? > > — > Reply to this email directly, view it on GitHub, or unsubscribe. > Triage notifications on the go with GitHub Mobile for iOS or Android. > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[ahmubashshir]

The autogenerated completion for zsh is a bit buggy, it autocompletes path even if the command will not accept the path.

these ones are autogenerated.

[NicolaSmaniotto]

PR #174 is a good thing, thanks @ahmubashshir. I'd have opened it myself, but I'm not familiar with the AUR's licensing.

As soon as I have some time I'll play a bit with cleo's autogenerated completions, those would solve every issue.

[NicolaSmaniotto]

The autogenerated completion for zsh is a bit buggy, it autocompletes path even if the command will not accept the path.

This seems to be python-poetry/cleo#85, which would be solved by merging python-poetry/cleo#86.

[iamkroot]

Yeah, the cleo autogenerated completions don't seem to support sub-commands. It is only providing top-level command completions, along with their optional flags.

I realize, this is closely related to poetry's commands using --verb style args to handle subcommands (they do poetry config --list instead of poetry config list). Not sure I like passing subcommands as flags. (Poetry and cleo were written by the same person)

@ahmubashshir's completions are definitely more complete (pardon the pun :P)

[NicolaSmaniotto]

My thought exactly. It's sad, but cleo seems to be pretty limited to what the dev needs it to do for poetry.

The issue to complete subcommands was opened as python-poetry/cleo#84 in september 2020, with ho response yet.

I patched my cleo install with python-poetry/cleo#86, and it solves the "bad set [...] array" problem, but that too was opened in september 2020 and still not merged.

I agree that the best approach for now is #174, at least until cleo adds the missing features.