Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Occitan locale file #551

Merged
merged 6 commits into from
Apr 2, 2019
Merged

Adds Occitan locale file #551

merged 6 commits into from
Apr 2, 2019

Conversation

Quenty31
Copy link
Contributor

In its general / central dialect

In its general / central dialect
@codecov-io
Copy link

codecov-io commented Mar 31, 2019

Codecov Report

Merging #551 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #551   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       152    153    +1     
  Lines       955    957    +2     
  Branches    128    127    -1     
===================================
+ Hits        955    957    +2
Impacted Files Coverage Δ
src/locale/oc-lnc.js 100% <100%> (ø)
src/locale/he.js 100% <0%> (ø) ⬆️
src/locale/zh-tw.js 100% <0%> (ø) ⬆️
src/locale/lt.js 100% <0%> (ø) ⬆️
src/index.js 100% <0%> (ø) ⬆️
src/locale/zh-cn.js 100% <0%> (ø) ⬆️
src/locale/fi.js 100% <0%> (ø) ⬆️
src/locale/ca.js 100% <0%> (ø) ⬆️
src/locale/ja.js 100% <0%> (ø) ⬆️
src/locale/cs.js 100% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e925de6...74ec1d3. Read the comment docs.

src/locale/oc.js Outdated
import dayjs from 'dayjs'

const locale = {
name: 'ca',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: 'ca',
name: 'oc',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks!

@iamkun
Copy link
Owner

iamkun commented Apr 1, 2019

https://github.com/moment/moment/blob/develop/src/locale/oc-lnc.js

what's the difference between oc and oc-lnc, please?

@Quenty31
Copy link
Contributor Author

Quenty31 commented Apr 1, 2019

There is no difference, if I put only «oc» it means «lengadocian» occitan. It's almost the standard, but we don’t have a standard form, the lengadocian is the most central dialect.

@iamkun
Copy link
Owner

iamkun commented Apr 1, 2019

@Quenty31 should we keep the same with moment.js and change to oc-lnc as well?

@Quenty31
Copy link
Contributor Author

Quenty31 commented Apr 1, 2019

It's up to you, both are correct, but if you want to use the same as moment.js, feel free to rename it :)

@iamkun
Copy link
Owner

iamkun commented Apr 1, 2019

Please keep the same with moment.js then. 😁

@iamkun
Copy link
Owner

iamkun commented Apr 1, 2019

and update name: 'oc',, please.

@iamkun iamkun merged commit c30b715 into iamkun:dev Apr 2, 2019
iamkun pushed a commit that referenced this pull request Apr 2, 2019
## [1.8.12](v1.8.11...v1.8.12) (2019-04-02)

### Bug Fixes

* Add .get API ([7318797](7318797))
* Add 79 locales ([#541](#541)) ([f75a125](f75a125))
* Add Calendar plugin ([d1b9cf9](d1b9cf9))
* Add isoWeeksInYear plugin ([2db8631](2db8631))
* Add Occitan (oc-lnc) locale file ([#551](#551)) ([c30b715](c30b715))
* Add plugin minMax to sopport .max .min ([2870a23](2870a23))
* Fix set Month Year error in last day of the month ([d058f4a](d058f4a))
* Update ko locale weekdaysShort  ([#543](#543)) ([317fd3e](317fd3e))
* Update localizedFormat plugin to support lowercase localizable formats (l, ll, lll, llll) ([#546](#546)) ([f2b5ebf](f2b5ebf))
@iamkun
Copy link
Owner

iamkun commented Apr 2, 2019

🎉 This PR is included in version 1.8.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Apr 2, 2019
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.12](iamkun/dayjs@v1.8.11...v1.8.12) (2019-04-02)

### Bug Fixes

* Add .get API ([7318797](iamkun/dayjs@7318797))
* Add 79 locales ([#541](iamkun/dayjs#541)) ([f75a125](iamkun/dayjs@f75a125))
* Add Calendar plugin ([d1b9cf9](iamkun/dayjs@d1b9cf9))
* Add isoWeeksInYear plugin ([2db8631](iamkun/dayjs@2db8631))
* Add Occitan (oc-lnc) locale file ([#551](iamkun/dayjs#551)) ([c30b715](iamkun/dayjs@c30b715))
* Add plugin minMax to sopport .max .min ([2870a23](iamkun/dayjs@2870a23))
* Fix set Month Year error in last day of the month ([d058f4a](iamkun/dayjs@d058f4a))
* Update ko locale weekdaysShort  ([#543](iamkun/dayjs#543)) ([317fd3e](iamkun/dayjs@317fd3e))
* Update localizedFormat plugin to support lowercase localizable formats (l, ll, lll, llll) ([#546](iamkun/dayjs#546)) ([f2b5ebf](iamkun/dayjs@f2b5ebf))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.12](iamkun/dayjs@v1.8.11...v1.8.12) (2019-04-02)

### Bug Fixes

* Add .get API ([7318797](iamkun/dayjs@7318797))
* Add 79 locales ([#541](iamkun/dayjs#541)) ([f75a125](iamkun/dayjs@f75a125))
* Add Calendar plugin ([d1b9cf9](iamkun/dayjs@d1b9cf9))
* Add isoWeeksInYear plugin ([2db8631](iamkun/dayjs@2db8631))
* Add Occitan (oc-lnc) locale file ([#551](iamkun/dayjs#551)) ([c30b715](iamkun/dayjs@c30b715))
* Add plugin minMax to sopport .max .min ([2870a23](iamkun/dayjs@2870a23))
* Fix set Month Year error in last day of the month ([d058f4a](iamkun/dayjs@d058f4a))
* Update ko locale weekdaysShort  ([#543](iamkun/dayjs#543)) ([317fd3e](iamkun/dayjs@317fd3e))
* Update localizedFormat plugin to support lowercase localizable formats (l, ll, lll, llll) ([#546](iamkun/dayjs#546)) ([f2b5ebf](iamkun/dayjs@f2b5ebf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants