Add 79 missing locales #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #541 +/- ##
====================================
Coverage 100% 100%
====================================
Files 70 149 +79
Lines 681 918 +237
Branches 119 119
====================================
+ Hits 681 918 +237
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #541 +/- ##
====================================
Coverage 100% 100%
====================================
Files 70 149 +79
Lines 681 918 +237
Branches 119 119
====================================
+ Hits 681 918 +237
Continue to review full report at Codecov.
|
iamkun
pushed a commit
that referenced
this pull request
Apr 2, 2019
## [1.8.12](v1.8.11...v1.8.12) (2019-04-02) ### Bug Fixes * Add .get API ([7318797](7318797)) * Add 79 locales ([#541](#541)) ([f75a125](f75a125)) * Add Calendar plugin ([d1b9cf9](d1b9cf9)) * Add isoWeeksInYear plugin ([2db8631](2db8631)) * Add Occitan (oc-lnc) locale file ([#551](#551)) ([c30b715](c30b715)) * Add plugin minMax to sopport .max .min ([2870a23](2870a23)) * Fix set Month Year error in last day of the month ([d058f4a](d058f4a)) * Update ko locale weekdaysShort ([#543](#543)) ([317fd3e](317fd3e)) * Update localizedFormat plugin to support lowercase localizable formats (l, ll, lll, llll) ([#546](#546)) ([f2b5ebf](f2b5ebf))
|
🎉 This PR is included in version 1.8.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks @xxyuk ! |
sstur
reviewed
Jul 10, 2021
| name: 'en-au', | ||
| weekdays: 'Sunday_Monday_Tuesday_Wednesday_Thursday_Friday_Saturday'.split('_'), | ||
| months: 'January_February_March_April_May_June_July_August_September_October_November_December'.split('_'), | ||
| weekStart: 1, |
There was a problem hiding this comment.
I do not believe this is correct (or else Moment has changed it since you made this PR). According to Moment Australia has a weekStart of 0 (Sunday). I can't find a canonical source to back up either choice, but I wanted to point out that Day.js is deviating from Moment in this case. When tested on MacOS (System Preferences -> Languages & Region -> change Region to Australia) it appears that Australia starts their week on a Sunday.
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.12](iamkun/dayjs@v1.8.11...v1.8.12) (2019-04-02) ### Bug Fixes * Add .get API ([7318797](iamkun/dayjs@7318797)) * Add 79 locales ([#541](iamkun/dayjs#541)) ([f75a125](iamkun/dayjs@f75a125)) * Add Calendar plugin ([d1b9cf9](iamkun/dayjs@d1b9cf9)) * Add isoWeeksInYear plugin ([2db8631](iamkun/dayjs@2db8631)) * Add Occitan (oc-lnc) locale file ([#551](iamkun/dayjs#551)) ([c30b715](iamkun/dayjs@c30b715)) * Add plugin minMax to sopport .max .min ([2870a23](iamkun/dayjs@2870a23)) * Fix set Month Year error in last day of the month ([d058f4a](iamkun/dayjs@d058f4a)) * Update ko locale weekdaysShort ([#543](iamkun/dayjs#543)) ([317fd3e](iamkun/dayjs@317fd3e)) * Update localizedFormat plugin to support lowercase localizable formats (l, ll, lll, llll) ([#546](iamkun/dayjs#546)) ([f2b5ebf](iamkun/dayjs@f2b5ebf))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.12](iamkun/dayjs@v1.8.11...v1.8.12) (2019-04-02) ### Bug Fixes * Add .get API ([7318797](iamkun/dayjs@7318797)) * Add 79 locales ([#541](iamkun/dayjs#541)) ([f75a125](iamkun/dayjs@f75a125)) * Add Calendar plugin ([d1b9cf9](iamkun/dayjs@d1b9cf9)) * Add isoWeeksInYear plugin ([2db8631](iamkun/dayjs@2db8631)) * Add Occitan (oc-lnc) locale file ([#551](iamkun/dayjs#551)) ([c30b715](iamkun/dayjs@c30b715)) * Add plugin minMax to sopport .max .min ([2870a23](iamkun/dayjs@2870a23)) * Fix set Month Year error in last day of the month ([d058f4a](iamkun/dayjs@d058f4a)) * Update ko locale weekdaysShort ([#543](iamkun/dayjs#543)) ([317fd3e](iamkun/dayjs@317fd3e)) * Update localizedFormat plugin to support lowercase localizable formats (l, ll, lll, llll) ([#546](iamkun/dayjs#546)) ([f2b5ebf](iamkun/dayjs@f2b5ebf))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I wrote a script and copied all the missing locales from moment.js.
Just the most important parts like month name and week name.