Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isoWeek plugin typescript definition #827 #828

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Fix isoWeek plugin typescript definition #827 #828

merged 1 commit into from
Mar 9, 2020

Conversation

Toub
Copy link
Contributor

@Toub Toub commented Mar 9, 2020

Fix isoWeek plugin typescript definition.

#827

fix: #827

@Toub
Copy link
Contributor Author

Toub commented Mar 9, 2020

@iamkun here is the import fix

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #828 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #828   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          157       157           
  Lines         1148      1148           
  Branches       216       216           
=========================================
  Hits          1148      1148           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b7c03...66845db. Read the comment docs.

@iamkun iamkun merged commit 30aab0c into iamkun:dev Mar 9, 2020
@iamkun
Copy link
Owner

iamkun commented Mar 9, 2020

Thanks!

iamkun pushed a commit that referenced this pull request Mar 16, 2020
## [1.8.23](v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](#828)) ([30aab0c](30aab0c))
* Update Arabic (ar) locale relative time ([#836](#836)) ([14044c6](14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](#833)) ([f0d451f](f0d451f))
* Update Thai (th) locale relativeTime ([#826](#826)) ([63b7c03](63b7c03)), closes [#816](#816)
@iamkun
Copy link
Owner

iamkun commented Mar 16, 2020

🎉 This PR is included in version 1.8.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

epszaw pushed a commit to epszaw/dayjs that referenced this pull request Apr 7, 2020
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun@f9b8945))
* Fix IsoWeek plugin typescript definition ([iamkun#828](iamkun#828)) ([30aab0c](iamkun@30aab0c))
* Update Arabic (ar) locale relative time ([iamkun#836](iamkun#836)) ([14044c6](iamkun@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([iamkun#833](iamkun#833)) ([f0d451f](iamkun@f0d451f))
* Update Thai (th) locale relativeTime ([iamkun#826](iamkun#826)) ([63b7c03](iamkun@63b7c03)), closes [iamkun#816](iamkun#816)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c))
* Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f))
* Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c))
* Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f))
* Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using new isoWeek plugin: "error TS2304: Cannot find name 'UnitType'"
2 participants