Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arabic relative time #836

Merged
merged 1 commit into from Mar 16, 2020
Merged

Fix Arabic relative time #836

merged 1 commit into from Mar 16, 2020

Conversation

elbourki
Copy link
Contributor

ar-tn, ar-sa, ar-ma, etc... are surprisingly following the correct formatting for relative time. This one should too.

ar-tn, ar-sa, ar-ma, etc... are surprisingly following the correct formatting for relative time. This one should too.
@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #836 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #836   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       158    158           
  Lines      1189   1189           
  Branches    240    240           
===================================
  Hits       1189   1189
Impacted Files Coverage Δ
src/locale/ar.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d451f...83a5bc7. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Mar 16, 2020

THX

@iamkun iamkun merged commit 14044c6 into iamkun:dev Mar 16, 2020
iamkun pushed a commit that referenced this pull request Mar 16, 2020
## [1.8.23](v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](#828)) ([30aab0c](30aab0c))
* Update Arabic (ar) locale relative time ([#836](#836)) ([14044c6](14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](#833)) ([f0d451f](f0d451f))
* Update Thai (th) locale relativeTime ([#826](#826)) ([63b7c03](63b7c03)), closes [#816](#816)
@iamkun
Copy link
Owner

iamkun commented Mar 16, 2020

🎉 This PR is included in version 1.8.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

epszaw pushed a commit to epszaw/dayjs that referenced this pull request Apr 7, 2020
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun@f9b8945))
* Fix IsoWeek plugin typescript definition ([iamkun#828](iamkun#828)) ([30aab0c](iamkun@30aab0c))
* Update Arabic (ar) locale relative time ([iamkun#836](iamkun#836)) ([14044c6](iamkun@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([iamkun#833](iamkun#833)) ([f0d451f](iamkun@f0d451f))
* Update Thai (th) locale relativeTime ([iamkun#826](iamkun#826)) ([63b7c03](iamkun@63b7c03)), closes [iamkun#816](iamkun#816)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c))
* Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f))
* Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c))
* Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f))
* Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants