Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private/Protected Methods are seen as accessible #2

Closed
ianaldrighetti opened this issue Jun 14, 2014 · 2 comments
Closed

Private/Protected Methods are seen as accessible #2

ianaldrighetti opened this issue Jun 14, 2014 · 2 comments
Assignees
@ianaldrighetti
Labels
bug

Comments

@ianaldrighetti
Copy link
Owner

It seems as though LMMVC is not checking the visibility of methods before invoking them. So a method marked as private/protected can be accessed. While it won't end up working (call_user_func_array throws an error), it still should throw an exception as if the page doesn't exist.
@ianaldrighetti ianaldrighetti self-assigned this Jun 14, 2014
@ianaldrighetti
Copy link
Owner Author

I am also going to make it so static methods aren't accessible either.

@ianaldrighetti
Copy link
Owner Author

This is resolved as of commit 36d699d.

@ianaldrighetti ianaldrighetti mentioned this issue Jun 15, 2014
Merged
ianaldrighetti added a commit that referenced this issue Jun 15, 2014
@ianaldrighetti
Merge pull request #3 from ianaldrighetti/1.0.1
e54f937 
Issue #2 - LMMVC should throw PageNotFoundException when a method is private, protected or static.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianaldrighetti ianaldrighetti

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianaldrighetti