Issue #2 - LMMVC should throw PageNotFoundException when a method is private, protected or static. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ception if the method isn't public or is a static method. Added tests to ensure this doesn't happen again.
ianaldrighetti
added a commit
that referenced
this pull request
Jun 15, 2014
Issue #2 - LMMVC should throw PageNotFoundException when a method is private, protected or static.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #2, as LMMVC was not checking the visibility of a method in the controller object. Now the getMethodObject method of Application will throw a PageNotFoundException when the method is not public or is static.
This issue wasn't really a security problem because the
call_user_func_arrayfunction simply spat out an error saying the method was private/protected so couldn't be invoked.