Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial Security Issues: no shell for python subprocess #267

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

ianfhunter
Copy link
Owner

@ianfhunter ianfhunter commented Oct 12, 2022

Description

https://www.codefactor.io/repository/github/ianfhunter/gnoll/source/main/tests/python/util.py#L37

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Test Coverage (Additional test(s) without any extra code)
  • Documentation Improvements

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. They do not dramatically decrease the test coverage metric
  • All new and existing tests passed.
  • I give my permission for my code to be used in this project under this license and any future license terms

@ianfhunter ianfhunter changed the title no shell Trivial Security Issues: no shell for python subprocess Oct 12, 2022
@ianfhunter ianfhunter merged commit 8cc47ba into main Oct 12, 2022
@ianfhunter ianfhunter deleted the fix_security_bug branch October 12, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant