Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtest_minidebug test failed #118

Closed
topazus opened this issue Jan 14, 2024 · 6 comments
Closed

mtest_minidebug test failed #118

topazus opened this issue Jan 14, 2024 · 6 comments

Comments

@topazus
Copy link

topazus commented Jan 14, 2024

the source code: 14818b7

used the patch of #99

detaild build log: https://kojipkgs.fedoraproject.org/work/tasks/3313/111733313/build.log

@jtojnar
Copy link

jtojnar commented Mar 2, 2024

We are now experiencing it in Nixpkgs.

The build log looks the same until running tests:

@@ -499,7 +502,7 @@
 xz mtest.mdbg
 objcopy --add-section .gnu_debugdata=mtest.mdbg.xz mtest.strip
 mv mtest.strip mtest_minidebug
-PASS: mtest_minidebug
+FAIL: mtest_minidebug
 PASS: test_elf_32
 PASS: test_elf_64
 PASS: test_macho
@@ -531,52 +534,67 @@
 PASS: mtest
 PASS: xztest
 PASS: xztest_alloc
+=====================================================
+   package-unused version-unused: ./test-suite.log
+=====================================================
+
+# TOTAL: 35
+# PASS:  34
+# SKIP:  0
+# XFAIL: 0
+# FAIL:  1
+# XPASS: 0
+# ERROR: 0
+
+.. contents:: :depth: 2
+
+FAIL: mtest_minidebug
+=====================
+
+test1: [0]: syminfo did not find name
+test1: [1]: syminfo did not find name
+test1: [2]: syminfo did not find name
+test1: [0]: missing function name
+test1: [1]: missing function name
+test1: [2]: missing function name
+test3: [0]: NULL syminfo name
+test3: [1]: NULL syminfo name
+test3: [2]: NULL syminfo name
+test5: NULL syminfo name
+FAIL: backtrace_full noinline
+FAIL: backtrace_simple noinline
+FAIL: backtrace_syminfo variable
+FAIL mtest_minidebug (exit status: 1)
+
 ============================================================================
 Testsuite summary for package-unused version-unused
 ============================================================================
 # TOTAL: 35
-# PASS:  35
+# PASS:  34
 # SKIP:  0
 # XFAIL: 0
-# FAIL:  0
+# FAIL:  1
 # XPASS: 0
 # ERROR: 0
 ============================================================================
+See ./test-suite.log
+============================================================================
+make[2]: *** [Makefile:2028: test-suite.log] Error 1

The test-suite.log just contains the same thing as above:

FAIL: mtest_minidebug
=====================

test1: [0]: syminfo did not find name
test1: [1]: syminfo did not find name
test1: [2]: syminfo did not find name
test1: [0]: missing function name
test1: [1]: missing function name
test1: [2]: missing function name
test3: [0]: NULL syminfo name
test3: [1]: NULL syminfo name
test3: [2]: NULL syminfo name
test5: NULL syminfo name
FAIL: backtrace_full noinline
FAIL: backtrace_simple noinline
FAIL: backtrace_syminfo variable
FAIL mtest_minidebug (exit status: 1)

@ianlancetaylor
Copy link
Owner

The test does pass for me on x86_64 on Ubuntu Rodete. Tell me more about the environment in which it fails.

@mweinelt
Copy link

mweinelt commented Mar 2, 2024

I could bisect this error to our (nixpkgs) xz upgrade from 5.4.6 to 5.6.0.

@trofi
Copy link

trofi commented Mar 2, 2024

tukaani-project/xz@6daa4d0 xz: Use threaded mode by defaut (as if --threads=0 was used). upstream change caused the test failures in libbacktrace.

@trofi
Copy link

trofi commented Mar 2, 2024

Using XZ_OPT="--trheads=2" environment variable I was able to reproduce the test failures on xz-5.4.6 as well.

ianlancetaylor added a commit to ianlancetaylor/cgosymbolizer that referenced this issue Mar 2, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
@ianlancetaylor
Copy link
Owner

Thanks for finding out how to reproduce the problem. Should be fixed now.

hubot pushed a commit to gcc-mirror/gcc that referenced this issue Mar 2, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
wangliu-iscas pushed a commit to plctlab/patchwork-gcc that referenced this issue Mar 2, 2024
This patch to libbacktrace corrects the LZMA block header parsing to
skip all the padding bytes, verifying that they are zero.  This fixes
ianlancetaylor/libbacktrace#118.
Bootstrapped and ran libbacktrace tests on x86_64-pc-linux-gnu.  I was
able to verify that the problem occurred when setting the environment
variable XZ_OPT="--threads=2", and that this patch fixes the bug.
Committed to mainline.

Ian

* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
and verify that they are zero.
23f9fbed3c97ed70d2615d7d3fa7c249cc862553
Liaoshihua pushed a commit to Liaoshihua/ruyi-gcc that referenced this issue Mar 11, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
Liaoshihua pushed a commit to Liaoshihua/ruyi-gcc that referenced this issue Mar 11, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
Liaoshihua pushed a commit to Liaoshihua/ruyi-gcc that referenced this issue Mar 11, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
Liaoshihua pushed a commit to Liaoshihua/ruyi-gcc that referenced this issue Mar 11, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
Liaoshihua pushed a commit to Liaoshihua/ruyi-gcc that referenced this issue Mar 11, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
Liaoshihua pushed a commit to Liaoshihua/ruyi-gcc that referenced this issue Mar 11, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
Liaoshihua pushed a commit to Liaoshihua/ruyi-gcc that referenced this issue Mar 11, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
Liaoshihua pushed a commit to Liaoshihua/ruyi-gcc that referenced this issue Mar 11, 2024
Fixes ianlancetaylor/libbacktrace#118

	* elf.c (elf_uncompress_lzma_block): Skip all header padding bytes
	and verify that they are zero.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants