Fix warnings regarding pointer arithmetics with void * #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
force-pushed
the
b-pointer-arith
branch
from
fc924e2
to
a5481a2
Compare
krlmlr
force-pushed
the
b-pointer-arith
branch
from
a5481a2
to
e1d6f5a
Compare
johnsonjh
added a commit
to johnsonjh/libbacktrace
that referenced
this pull request
Feb 2, 2023
cooljeanius
reviewed
Aug 4, 2024
| @@ -678,7 +678,7 @@ coff_add (struct backtrace_state *state, int descriptor, | |||
| sects_view_valid = 1; | |||
| opt_hdr = (const b_coff_optional_header *) sects_view.data; | |||
| sects = (const b_coff_section_header *) | |||
| (sects_view.data + fhdr.size_of_optional_header); | |||
| (void *)((const char *)sects_view.data + fhdr.size_of_optional_header); | |||
There was a problem hiding this comment.
...so, including the unchanged one on the previous line, that's what, 3 casts in a row here? I wonder if there's a way to make that more efficient?
There was a problem hiding this comment.
Casts don't carry any runtime cost, so there is efficiency issue here.
|
Thanks. I committed a version of your change upstream and merged the patch back into this repo in 6ce91a2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling with
-Wpointer-arithtriggers the following warnings: