Reverted 03861af (#4804) and added a test for the exception it caused (…

…#4858)
ianstormtaylor · Mar 2, 2022 · 33be22f · 33be22f
1 parent 442d263
commit 33be22f
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 2 deletions.
diff --git a/.changeset/purple-walls-kiss.md b/.changeset/purple-walls-kiss.md
@@ -0,0 +1,5 @@
+---
+'slate': patch
+---
+
+Reverted #4804 as it triggered an exception when inserting text with multi-block selection
diff --git a/packages/slate/src/transforms/text.ts b/packages/slate/src/transforms/text.ts
@@ -487,8 +487,7 @@ export const TextTransforms: TextTransforms = {
           if (!voids && Editor.void(editor, { at: end })) {
             return
           }
-          const start = Range.start(at)
-          const pointRef = Editor.pointRef(editor, start)
+          const pointRef = Editor.pointRef(editor, end)
           Transforms.delete(editor, { at, voids })
           at = pointRef.unref()!
           Transforms.setSelection(editor, { anchor: at, focus: at })

diff --git a/packages/slate/test/transforms/insertText/selection/block-across.tsx b/packages/slate/test/transforms/insertText/selection/block-across.tsx
@@ -0,0 +1,26 @@
+/** @jsx jsx */
+import { Transforms } from 'slate'
+import { jsx } from '../../..'
+
+export const run = editor => {
+  Transforms.insertText(editor, 'a')
+}
+export const input = (
+  <editor>
+    <block>
+      <anchor />
+      first paragraph
+    </block>
+    <block>
+      second
+      <focus /> paragraph
+    </block>
+  </editor>
+)
+export const output = (
+  <editor>
+    <block>
+      a<cursor /> paragraph
+    </block>
+  </editor>
+)