-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected delete behavior in android #2702
Comments
@hecor Thanks for the screencast. Just to clarify what you are doing here. You go to the end of a line and hit enter. Insert a word either through IME or regular means. Hitting enter deletes the entire word instead of one character. I'll take a look after I migrate the Android plugins to use some new constructs I'm working on. I think I know what's happening though. |
@thesunny Thanks for the quick reply. |
@hecor I'm not sure what's going on exactly until I do some more analysis but my guess is that the delete in Android is doing something nasty and so we take a DOM snapshot before doing the delete. However, it's probably using the wrong snapshot, one that was taken before the text was entered. I'll look out for this when I get back to that part of the code. |
OK, hope to have your good news soon~ |
I think this bug is fixed now. You can test it out here: https://thesunny.github.io/slate/#/rich-text Edit: Fixed but not merged into |
I'm working on fixing the remaining Android bugs now. In order to be more efficient, please submit bugs and help with testing over in this issue: Fix all showstopper bugs in Slate on Android (Help us by reporting and testing bugs) |
For me it's worse with this fixes: Oneplus 5t, android 9, gboard Same problems + crash in the end on mediapad m5, android 8: (i'm NOT saying this was much better for me before this fix) |
Can you tell me if it works on your browser if you release backspace before the start of block? I haven’t tested arbitrarily long deletes through blocks and I can see why it would fail but I want to make sure the non wrapping use case is fixed. It works for me. It can be difficult to tell if it’s a bug because it’s a different browser environment or a different action so I’d like to make sure that you see my in line backspace behavior. The select delete issue I haven’t tested. That’s a separate bug. That one might be hard. |
Hi @thesunny It didn't fix my problem too, actually my another Huawei android phone which is fine before have the same problem now. |
@hecor can you clarify that you can or cannot hold down backspace and release before you cross the start of the line and have it work? Try these tests I made here: https://thesunny.github.io/slate/#/composition/delete If you can't do that, this might be an issue that doesn't present on the simulator but does present on hardware which will be painful to work on. Also, please let me know Android API version and device names and which ones worked before and don't work now. By the way, I haven't incorporated any Android 7 fixes into this version of the code yet so those will not work at all. Note: The select then delete is a separate issue. As is the issue of holding backspace through the start of line. Also, could you let me know if hitting delete one at a time causes issues? |
@hecor @AnatolyShirykalov @glebtv Can you let me know how you made the screen recordings? I would like to add the tool to the bug reporting post I made. |
Although this thread seems to be talking about one issue, it is actually several. When talking about an issue, please refer to it's number below. If I believe the issue is fixed, I will check it:
@glebtv thank you so much for the bug posts but I am having trouble reliably recreating these issues. I'm not convinced this is a difference from the simulator yet (although it could be). A big help would be to be very specific about the actions starting with the pre-existing content. There appears to be some content missing from the start in the scenarios. In other words, starting from fresh content. What exactly did you type. How did you type it? (gesture, one key at a time) How did you delete it? One backspace at a time or hold down the delete? In Android, unlike the other browsers, you don't handle |
I think I've re-reported a few mentioned here. Here's my best guesses as to mapping issues here to my new reports.
Anything left on this list in a few days I'll try to figure out how to re-create, if they still can be. |
Hold everything. The fix to the range deletions broke the regular deletions. |
It is very easily reproducuble for me, just deleted some text by holding backspace, allowing delete to wrap over multiple paragraphs. This is hardware, not emulator. I have some keyboard settings configured, like autocorrect and suggestions disabled on gboard. Also, slate value in composition demo doesnt change for me in most of editing scenarios, although some work. Here is an updated video with slate value included, from oneplus 5t, including crash at the end. https://www.dropbox.com/s/1stgqocg8joi4td/2019_05_03_09_39_32.mp4?dl=0 - adding as a real video so you can pause/rewind. When the key I press is not visible, it is backspace. (gboard does not highlight it on press somewhy) Crash is hard to reproduce for me (1 crash per 3-5 minutes), but incorrect update of slate value and reappear of deleted content are easy / all the time. |
Hey, there are lots of open Android-related issues that are out of date with the latest If it cannot be implemented simply in core with Thank you for understanding. |
Do you want to request a feature or report a bug?
Bug.
What's the current behavior?
What's the expected behavior?
Delete a character each time.
system
Vivo phone, android 8.1
The text was updated successfully, but these errors were encountered: