Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android support for Slate 0.50 #3112

Open
gracicot opened this issue Nov 12, 2019 · 1 comment
Open

Android support for Slate 0.50 #3112

gracicot opened this issue Nov 12, 2019 · 1 comment

Comments

@gracicot
Copy link
Contributor

Do you want to request a feature or report a bug?

Feature/Bug

What's the current behavior?

The next branch removed the Android plugin because the large amount of changes made it incompatible. This brings back writing issues on Android.

Basic writing and swipe typing works, but outside of that Slate next is not doing so well depite the impovement reguarding beforeinput.

Changing the selection, autocompletion, word suggestion and other are now problems.

Here's some videos:
Changing the selection
Autocomplete and word suggestions
Deleting backward

All of these videos are in the plain text example.

What's the expected behavior?

The editing on android should not have such surprising behaviour for such basic cases. The composition manager should bring back a decent level of stability on Android.

@ianstormtaylor
Copy link
Owner

Thanks @gracicot these are awesome!

There are probably still some bugs in the next branch for non-Android behaviors as well. I haven't tested it well with spellcheck/autosuggest/etc. inputs yet. And I have only done a tiny tweak for compositionend to get the basics working Chrome.

So there might be more low-hanging fruit we can do before jumping to the mutation events or a composition manager. I'd be curious to see what the ordering of events is for these common cases like "deleting a letter", "inserting a letter", etc.

For example, here's Alt–E E in Chrome on the desktop:

https://input-inspector.now.sh/profiles/nBscvOl24uSfbYJarsPb

image

@ianstormtaylor ianstormtaylor changed the title Reintegrate the Android plugin into Next Android support for Slate 0.50 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants