Add prop "isFocused" / "isSelected" for custom nodes #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @SamyPesse this looks good to me. Can you update the examples that use |
SamyPesse
commented
Jul 3, 2018
| return ( | ||
| <div {...this.props.attributes}> | ||
| {this.renderVideo()} | ||
| {this.renderInput()} | ||
| {isSelected ? this.renderInput() : null} |
There was a problem hiding this comment.
I've adapted this example to show the input only when the node is selected.
|
Thanks @SamyPesse, this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for a breaking change. It changes the definition of the prop
isSelectedfor custom nodes, and add a propisFocused.Basically
isFocusedis equal to the previousisSelected.In my opinion, these names better match the other concept in slate: something can be selected without being focused.
Upgrade path
Developers depending on
isSelectedwill have to rename it toisFocused. It should be easy (Search & replace).TODOs
isSelectedandisFocusedslate-react