Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update an example's link #3514

Merged
merged 1 commit into from Feb 23, 2020

Conversation

chengluyu
Copy link
Contributor

The "hovering menu" example doesn't exists. Instead, there's an example called "hovering toolbar". So I update the link to that example.

Is this adding or improving a feature or fixing a bug?

Nope.

What's the new behavior?

Nope.

How does this change work?

I just fixed an unreachable link.

Have you checked that...?

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)

Does this fix any issues or need any specific reviewers?

No.

@cameracker
Copy link
Collaborator

Thanks so much for catching this issue! Really appreciate the PR :)

@cameracker cameracker merged commit 0d6271b into ianstormtaylor:master Feb 23, 2020
thallada pushed a commit to considerhq/slate that referenced this pull request Feb 26, 2020
pzhine pushed a commit to databyss-org/slate that referenced this pull request May 17, 2020
lukesmurray pushed a commit to lukesmurray/slate that referenced this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants