[slate-react]: fix selection bugs when multiple editors share value #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 96e50f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
skogsmaskin
force-pushed
the
fix/instance-weakmaps
branch
2 times, most recently
from
4aaba18
to
39114a3
Compare
The KEY_TO_ELEMENT weakmap must be scoped to the instance to avoid collisions between multiple editors. This is solved by wrapping it in another WeakMap keyed on the editor object, that returns the KEY_TO_ELEMENT Weakmap for that editor.
skogsmaskin
force-pushed
the
fix/instance-weakmaps
branch
from
39114a3
to
6d5c418
Compare
dylans
approved these changes
Aug 25, 2021
skogsmaskin
added a commit
to skogsmaskin/slate
that referenced
this pull request
Aug 25, 2021
This can be ignored once we upgrade. Fixed upstream here: ianstormtaylor#4475
Merged
This was referenced Aug 25, 2021
Closed
dylans
added a commit
to dylans/slate
that referenced
this pull request
Sep 13, 2021
…anstormtaylor#4475) * [slate-react]: fix selection bugs when multiple editors share value The KEY_TO_ELEMENT weakmap must be scoped to the instance to avoid collisions between multiple editors. This is solved by wrapping it in another WeakMap keyed on the editor object, that returns the KEY_TO_ELEMENT Weakmap for that editor. * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
KEY_TO_ELEMENTWeakMap must be scoped to the editor instance to avoid collisions between multiple editors in the same DOM that share the same editor value (object equality onNode).This is solved by wrapping it in another WeakMap keyed on the editor object, that returns the
KEY_TO_ELEMENTWeakMap for that editor.It could also be solved by just putting the
KEY_TO_ELEMENTWeakmap directly on the editor instance, but I didn't want to tangle theReactEditorinterface with these (internal) things and keep using weak-maps only for this logic.Issue
Fixes:
#3380
#3997
#4129
Example
This will illustrate the problem:
Then try the same on the deployed preview: https://deploy-preview-4475--slatejs.netlify.app/examples/editable-voids to confirm the fix.
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)