Editable button example: emulate button to work around browser bug #4630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately the "editable button" example I introduced has a bug on Chrome and Safari, where the cursor jumps around wrongly when using the "up" and "down" keys to navigate. This is due to a browser bug with
display:inline-block
elements, and there is no known workaround except to usedisplay:inline
.I considered entirely replacing the "button" example with something else, but decided it's important for our examples to show real-world problems and solutions, regardless of whether they're ugly. Also, I leave this here in the hope that someone else comes along with a better workaround.
Video
The current bug at https://www.slatejs.org/examples/inlines in Chrome:
chrome-contenteditable-displayinlineblock-bug.mp4
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)