Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return of the configuration file #1251

Merged
merged 13 commits into from Jun 19, 2022
Merged

Return of the configuration file #1251

merged 13 commits into from Jun 19, 2022

Conversation

ianyh
Copy link
Owner

@ianyh ianyh commented May 29, 2022

  • Support yaml
  • Update tests to cover yaml configs in addition to json
  • Add example yaml config
  • Add config documentation

@rickythefox
Copy link
Contributor

image

We probably should be able to add window title restrictions?

@ianyh ianyh marked this pull request as ready for review June 19, 2022 03:07
@ianyh ianyh merged commit def9a49 into development Jun 19, 2022
@ianyh ianyh deleted the dotfile branch June 19, 2022 03:07
ajorpheus pushed a commit to ajorpheus/Amethyst that referenced this pull request Jul 14, 2022
* Add yaml-supported config

* Add yaml config to config tests

* Documentation for the dotfile

* Add a sample .amethyst

* Use .yml extension for .amethyst

* Minor swiftlint config change

* Remove unused functions

* Fix types from YAML decoding

* Use a floating bundle format that is possible in yaml

* Treat yaml parse failure as error log

* Reference configuration files from the main readme

* Incorrect test

* Fix the filename for config sample
@joech4n
Copy link

joech4n commented Oct 30, 2022

We probably should be able to add window title restrictions?

Is this currently possible? I don't see the option at https://github.com/ianyh/Amethyst/blob/development/docs/configuration-files.md

Edit: It also seems like any window title restriction configured via the GUI is wiped on restart when using .amethyst.yml. Perhaps this is better served by creating a new issue. Created #1334.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants