Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set cookie or gather referrer on DNT #69

Closed
wants to merge 1 commit into from

Conversation

alpipego
Copy link
Contributor

@alpipego alpipego commented May 8, 2020

if a user has set Do Not Track, don't set a cookie (even if the setting
is enabled) and don't try to get the referrer, fixes #68.

if a user has set Do Not Track, don't set a cookie (even if the setting
  is enabled) and don't try to get the referrer, fixes ibericode#68.
@dannyvankooten
Copy link
Member

Hey @alpipego,

I'm afraid I can't merge this right away as it changes the default behavior of the plugin and in turn will effect statistics for people who've been running Koko Analytics for a while now. I also think it's debatable what doNotTrack actually means and what users want it to do, e.g. people might also use it to signal they don't want to waste any unnecessary bandwidth when data is limited (large parts of the world).

What we can do is make this configurable through a filter hook by adding a property to the window.koko_analytics configuration object. Would that work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor "Do Not Track" while still counting page views
2 participants