Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7574: Hidded label in doughnut chart when unchecked #1179

Merged
merged 6 commits into from
Mar 11, 2024
Merged

IBX-7574: Hidded label in doughnut chart when unchecked #1179

merged 6 commits into from
Mar 11, 2024

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Feb 16, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7574
Type bug
Target version v4.6
BC breaks no
Doc needed no
Required https://github.com/ibexa/order-management/pull/111
Required

What is done:

  1. Moved logic from packages: product catalog and order management to doughtnut chart.
  2. Hidded datalabels label in doughnut chart when unchecked legend.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@Gengar-i Gengar-i force-pushed the ibx-7574-hidding-chart-js-label branch from aa99321 to 1e89f79 Compare March 8, 2024 11:14
@juskora juskora mentioned this pull request Mar 8, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@juskora
Copy link
Contributor

juskora commented Mar 11, 2024

QA Approved on Ibexa DXP Commerce 4.6-dev.

@dew326 dew326 merged commit d52ddc9 into main Mar 11, 2024
22 checks passed
@dew326 dew326 deleted the ibx-7574-hidding-chart-js-label branch March 11, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@juskora juskora juskora approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gengar-i @juskora @GrabowskiM @dew326 @lucasOsti