Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7833: Added pagination to relation tab #1195

Merged
merged 2 commits into from
Apr 23, 2024
Merged

IBX-7833: Added pagination to relation tab #1195

merged 2 commits into from
Apr 23, 2024

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Feb 28, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7833
Type bug
Target version v4.5
BC breaks no
Doc needed no

Depends on ibexa/core#343

Regressions test: ibexa/commerce#724

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • [] Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Feb 28, 2024
@mateuszdebinski mateuszdebinski requested review from a team February 28, 2024 16:20
@mateuszdebinski mateuszdebinski self-assigned this Feb 28, 2024
ViniTou
ViniTou approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could add that core dependency here tho, as this is a lot of failing CI builds.

@micszo micszo mentioned this pull request Feb 29, 2024
Closed
@mateuszdebinski
Copy link
Contributor Author

mateuszdebinski commented Feb 29, 2024 •
edited
Loading

It would be great if you could add that core dependency here tho, as this is a lot of failing CI builds.

Regressions test are green :)

@GrabowskiM GrabowskiM requested a review from a team February 29, 2024 10:30
konradoboza
konradoboza reviewed Mar 4, 2024
View reviewed changes
phpstan-baseline.neon Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team March 4, 2024 07:21
@konradoboza konradoboza requested a review from a team March 4, 2024 09:50
@alongosz alongosz mentioned this pull request Mar 7, 2024
Merged
6 tasks
alongosz
alongosz reviewed Mar 7, 2024
View reviewed changes
phpstan-baseline.neon Outdated Show resolved Hide resolved
src/bundle/Controller/ContentViewController.php Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@micszo micszo self-assigned this Apr 17, 2024
@mateuszdebinski mateuszdebinski force-pushed the IBX-7833_add_pagination_to_relation_tab branch from e55181a to 2940156 Compare April 19, 2024 11:47
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@micszo micszo removed their assignment Apr 22, 2024
@dew326 dew326 merged commit 485fe0c into 4.5 Apr 23, 2024
16 checks passed
@dew326 dew326 deleted the IBX-7833_add_pagination_to_relation_tab branch April 23, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@mateuszdebinski @GrabowskiM @alongosz @dew326 @micszo @ViniTou @konradoboza @mikadamczyk @Nattfarinn @ciastektk