Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7833: [PAPI] Implemented loading paginated relation list #343

Merged
merged 9 commits into from
Apr 22, 2024
Merged

IBX-7833: [PAPI] Implemented loading paginated relation list #343

merged 9 commits into from
Apr 22, 2024

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Feb 28, 2024 •
edited by alongosz
Loading

Question Answer
JIRA issue IBX-7833
Required by ibexa/admin-ui#1195
Type bug/improvement
Target Ibexa version v4.5
BC breaks no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Feb 28, 2024
@mateuszdebinski mateuszdebinski requested a review from a team February 28, 2024 16:19
@mateuszdebinski mateuszdebinski self-assigned this Feb 28, 2024
@mateuszdebinski mateuszdebinski mentioned this pull request Feb 28, 2024
Merged
4 tasks
@micszo micszo mentioned this pull request Feb 29, 2024
Closed
alongosz
alongosz requested changes Feb 29, 2024
View reviewed changes
phpstan-baseline.neon Outdated Show resolved Hide resolved
@mateuszdebinski mateuszdebinski requested review from alongosz and a team February 29, 2024 10:01
konradoboza
konradoboza reviewed Mar 4, 2024
View reviewed changes
src/contracts/Persistence/Content/Handler.php Outdated Show resolved Hide resolved
src/lib/Persistence/Legacy/Content/Gateway.php Outdated Show resolved Hide resolved
src/lib/Persistence/Legacy/Content/Gateway.php Outdated Show resolved Hide resolved
tests/integration/Core/Repository/ContentServiceTest.php Outdated Show resolved Hide resolved
tests/integration/Core/Repository/ContentServiceTest.php Outdated Show resolved Hide resolved
tests/integration/Core/Repository/ContentServiceTest.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team March 4, 2024 07:21
@konradoboza konradoboza requested a review from a team March 4, 2024 10:27
Steveb-p
Steveb-p reviewed Mar 4, 2024
View reviewed changes
src/lib/Persistence/Cache/ContentHandler.php Outdated Show resolved Hide resolved
src/lib/Persistence/Cache/ContentHandler.php Outdated Show resolved Hide resolved
src/lib/Persistence/Legacy/Content/Gateway.php Outdated Show resolved Hide resolved
src/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php Outdated Show resolved Hide resolved
src/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php Outdated Show resolved Hide resolved
src/lib/Repository/ContentService.php Outdated Show resolved Hide resolved
tests/integration/Core/Repository/ContentServiceTest.php Outdated Show resolved Hide resolved
@alongosz alongosz changed the title IBX-7833: Added pagination to relation tab IBX-7833: [PAPI] Implemented loading paginated relation list Mar 7, 2024
alongosz
alongosz reviewed Mar 7, 2024
View reviewed changes
src/lib/Repository/SiteAccessAware/ContentService.php Outdated Show resolved Hide resolved
src/lib/Repository/SiteAccessAware/ContentService.php Outdated Show resolved Hide resolved
src/contracts/Repository/ContentService.php Outdated Show resolved Hide resolved
src/contracts/Repository/ContentService.php Outdated Show resolved Hide resolved
src/contracts/Repository/ContentService.php Outdated Show resolved Hide resolved
src/lib/Repository/ContentService.php Outdated Show resolved Hide resolved
src/lib/Repository/ContentService.php Outdated Show resolved Hide resolved
src/lib/Repository/ContentService.php Show resolved Hide resolved
src/lib/Repository/ContentService.php Outdated Show resolved Hide resolved
src/lib/Repository/ContentService.php Outdated Show resolved Hide resolved
@mateuszdebinski mateuszdebinski force-pushed the IBX-7833_add_pagination_to_relation_tab branch from 2fca92c to b75ee41 Compare March 22, 2024 09:03
@mateuszdebinski mateuszdebinski force-pushed the IBX-7833_add_pagination_to_relation_tab branch 2 times, most recently from 2745174 to 21534d5 Compare March 29, 2024 14:18
alongosz
alongosz reviewed Mar 29, 2024
View reviewed changes
src/contracts/Persistence/Content/Handler.php Outdated Show resolved Hide resolved
src/contracts/Persistence/Content/Handler.php Outdated Show resolved Hide resolved
src/contracts/Repository/ContentService.php Outdated Show resolved Hide resolved
src/contracts/Repository/ContentService.php Outdated Show resolved Hide resolved
src/lib/Persistence/Cache/ContentHandler.php Outdated Show resolved Hide resolved
src/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php Outdated Show resolved Hide resolved
src/lib/Repository/ContentService.php Outdated Show resolved Hide resolved
@alongosz alongosz requested a review from a team April 9, 2024 13:49
@micszo micszo self-assigned this Apr 17, 2024
@mateuszdebinski mateuszdebinski force-pushed the IBX-7833_add_pagination_to_relation_tab branch from 92aa04d to 935d176 Compare April 19, 2024 11:46
micszo
micszo approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.5.8-dev.

@micszo micszo removed their assignment Apr 22, 2024
@mateuszdebinski mateuszdebinski force-pushed the IBX-7833_add_pagination_to_relation_tab branch from 935d176 to 070d41d Compare April 22, 2024 13:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 4ccc0fa into 4.5 Apr 22, 2024
21 checks passed
@alongosz alongosz deleted the IBX-7833_add_pagination_to_relation_tab branch April 22, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mateuszdebinski @adamwojs @Steveb-p @alongosz @micszo @konradoboza @mikadamczyk @tischsoic