IBX-8195: Content items are displayed multiple times in UDW after adding item to bookmarks #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
approved these changes
May 20, 2024
dew326
approved these changes
May 20, 2024
…ing item to bookmarks
This was referenced May 22, 2024
katarzynazawada
requested changes
May 22, 2024
|
|
QA Approved on Ibexa DXP Commerce 4.6-dev. |
juskora
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Test case with loading more items (so > 50 items) thoroughly, I had some problems with it (infinite loading of items - after one batch was loaded, it tried to load next one (non-existing) by showing loader. After my fixes I couldn't reproduce these unnecessary loaders, so it should be fixed, but maybe there's still some corner case.
Also - this PR modifies solution from this issues https://issues.ibexa.co/browse/IBX-7839 as that one introduced IBX-8195 bug, so probably should be tested as well (checked that as well, looked that it works as well)
Documentation: