IBX-2628: Introduce colorful tag-like dropdown #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Mar 30, 2022
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-2628 |
| Bug fix? | no |
| New feature? | yes/no |
| BC breaks? | no |
| Tests pass? | yes |
| Doc needed? | yes/no |
| License | GPL-2.0 |
tischsoic
force-pushed
the
IBX-2628-introduce-colorful-tag-like-dropdown
branch
from
09a94a9
to
299ff4d
Compare
lucasOsti
reviewed
Mar 30, 2022
| &__selection-info { | ||
| height: calculateRem(24px); | ||
| padding-left: calculateRem(8px); | ||
| border-radius: calculateRem(12px); |
There was a problem hiding this comment.
new value for border-radius?
There was a problem hiding this comment.
The sides of this dropdown are fully rounded so we need a border radius that equals half of its height. 50% won't work because this is not a square and we do not want to have an ellipsis.
Merged
GrabowskiM
approved these changes
Apr 4, 2022
lucasOsti
approved these changes
Apr 15, 2022
tischsoic
force-pushed
the
IBX-2628-introduce-colorful-tag-like-dropdown
branch
from
ecb9fa8
to
8ecb81b
Compare
dew326
approved these changes
Apr 26, 2022
katarzynazawada
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.