IBX-2937: Added new relation starting location options #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2022
Nattfarinn
changed the title
Nattfarinn
force-pushed
the
ibx-2937-relation-children
branch
from
2ccd900
to
72b4c37
Compare
Nattfarinn
changed the title
Nattfarinn
force-pushed
the
ibx-2937-relation-children
branch
from
5451a3f
to
0efa2e5
Compare
Nattfarinn
force-pushed
the
ibx-2937-relation-children
branch
from
0efa2e5
to
530ce4d
Compare
Steveb-p
reviewed
Jul 4, 2022
src/bundle/Resources/views/themes/admin/content_type/relation_list_form_fields.html.twig
Show resolved
Hide resolved
| @@ -303,7 +303,7 @@ const UniversalDiscoveryModule = (props) => { | |||
| }, [currentView]); | |||
|
|
|||
| useEffect(() => { | |||
| if (!props.startingLocationId || props.startingLocationId === 1) { | |||
| if (!props.startingLocationId || props.startingLocationId === 1 || props.startingLocationId === props.rootLocationId) { | |||
There was a problem hiding this comment.
You should also update the dependencies of this hook (line :324).
Dependencies are responsible for establishing what properties will cause the useEffect hook to recalculate. In this case you're adding props.rootLocationId as part of this condition, so if it ever changes, it should cause useEffect to re-apply, just as props.startingLocationId does.
Although, from what I see, other dependencies are also missing (like currentView).
mikadamczyk
approved these changes
Jul 4, 2022
Steveb-p
approved these changes
Jul 5, 2022
Nattfarinn
force-pushed
the
ibx-2937-relation-children
branch
from
bb3bae5
to
2b27614
Compare
mnocon
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a stand alone PR.
Requires:
Checklist:
$ composer fix-cs)